Infer pcall's own return when the called function has none - #3440
Open
RomanSpector wants to merge 2 commits into
Open
Infer pcall's own return when the called function has none#3440RomanSpector wants to merge 2 commits into
RomanSpector wants to merge 2 commits into
Conversation
`getReturn` always yields a node — an empty one when there is nothing to take — so `if node then` passed even for a function declared as `fun()`. That empty node became the result and the type stayed unknown, although `pcall` declares its second result as `any`: on failure it carries the error value. An empty node is no longer accepted as an answer; compilation falls through to `pcall`'s own declaration instead. The same applies to `xpcall`, where the message handler's result takes the place of the missing return. Functions that do return a value are unaffected, as the existing tests cover. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pcallreturnsfalseplus the error value when the call fails, and the meta declares that second result asany. For a function declared asfun()it came out asunknowninstead:The compiler takes the called function's return under the same index and stops there.
getReturnalways yields a node — an empty one when there is nothing to take — so theif node thenguard passed even when the function returns nothing, and that empty node became the result.An empty node is no longer accepted as an answer: compilation falls through to
pcall's own declaration. The same applies toxpcall, where the message handler's result takes the place of the missing return.Functions that do return a value are unaffected — the existing tests cover that, and two new ones cover the case above.