Skip to content

fix(sorts): raise TypeError when bucket_count is not an integer in bucket_sort (#14970) - #14987

Open
TheRodzz wants to merge 4 commits into
TheAlgorithms:masterfrom
TheRodzz:fix-bucket-sort-float-count
Open

fix(sorts): raise TypeError when bucket_count is not an integer in bucket_sort (#14970)#14987
TheRodzz wants to merge 4 commits into
TheAlgorithms:masterfrom
TheRodzz:fix-bucket-sort-float-count

Conversation

@TheRodzz

Copy link
Copy Markdown

Describe your change:

Fixes #14970

Adds type validation to bucket_sort() to raise a TypeError when bucket_count is passed as a float (or non-integer) value, preventing internal TypeError exceptions when attempting to range over floats.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Jul 31, 2026
@TheRodzz
TheRodzz force-pushed the fix-bucket-sort-float-count branch from e025900 to 492c68c Compare July 31, 2026 17:08
@algorithms-keeper algorithms-keeper Bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bucket_sort has no dedicated error handling when the number of buckets in inputted as a float instead of an integer.

3 participants