Skip to content

chore(ui): improve width of containers - #9032

Open
avivkeller wants to merge 1 commit into
mainfrom
container-width
Open

chore(ui): improve width of containers#9032
avivkeller wants to merge 1 commit into
mainfrom
container-width

Conversation

@avivkeller

@avivkeller avivkeller commented Jul 28, 2026

Copy link
Copy Markdown
Member

Partially fix/es nodejs/doc-kit#954 by expanding the main content (if possible) and the change history

@avivkeller
avivkeller requested a review from a team as a code owner July 28, 2026 22:46
Copilot AI review requested due to automatic review settings July 28, 2026 22:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Aug 1, 2026 8:05pm

Request Review

@cursor

cursor Bot commented Jul 28, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
CSS-only layout tweak for a dropdown; no logic, auth, or data changes.

Overview
Widens the ChangeHistory version dropdown so longer labels fit better, addressing part of doc-kit layout feedback.

The dropdown panel moves from a fixed w-52 (~13rem) to w-[26rem] with max-w-[calc(100vw-2rem)] so it can grow on desktop but still stay inside the viewport on narrow screens. The inner scroll area uses w-full instead of a fixed width so it matches the wrapper.

Includes a patch changeset for @node-core/ui-components.

Reviewed by Cursor Bugbot for commit 2f372e4. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.10%. Comparing base (4aed720) to head (2f372e4).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9032   +/-   ##
=======================================
  Coverage   75.10%   75.10%           
=======================================
  Files         102      102           
  Lines        9106     9106           
  Branches      372      372           
=======================================
  Hits         6839     6839           
  Misses       2263     2263           
  Partials        4        4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 624748c. Configure here.

Comment thread packages/ui-components/src/Containers/Article/index.module.css
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 7.16 MB
New Total First Load JS 7.16 MB
Delta 0 B (0.00%)

Comment thread packages/ui-components/src/Containers/Article/index.module.css
@AugustinMauroy

Copy link
Copy Markdown
Member

Can we have stories for that change so if there are future change we will know what happened

@avivkeller

Copy link
Copy Markdown
Member Author

Can we have stories for that change so if there are future change we will know what happened

I don't know if stories will cover this kind of dynamic change

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should follow standards. Document @bjohansebas's comment explicitly.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 1, 2026 20:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (2)

packages/ui-components/src/Common/ChangeHistory/index.module.css:36

  • max-w-[calc(100vw-2rem)] produces calc(100vw-2rem) which is invalid CSS calc syntax (the - must be an operator, not part of the 2rem token). This can cause the max-width constraint to be ignored on small viewports.
    w-[26rem]
    max-w-[calc(100vw-2rem)]

.changeset/public-baths-open.md:5

  • The PR description mentions expanding the main content width (issue #954 also calls out increasing the page max width), but this PR only changes the ChangeHistory dropdown width. Either update the PR description/changeset to scope it to ChangeHistory only, or include the main content/container width change as well.
Improve the width of ChangeHistory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants