chore(ui): improve width of containers - #9032
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview The dropdown panel moves from a fixed Includes a patch changeset for Reviewed by Cursor Bugbot for commit 2f372e4. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9032 +/- ##
=======================================
Coverage 75.10% 75.10%
=======================================
Files 102 102
Lines 9106 9106
Branches 372 372
=======================================
Hits 6839 6839
Misses 2263 2263
Partials 4 4 ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 624748c. Configure here.
📦 Build Size ComparisonSummary
|
|
Can we have stories for that change so if there are future change we will know what happened |
I don't know if stories will cover this kind of dynamic change |
ovflowd
left a comment
There was a problem hiding this comment.
We should follow standards. Document @bjohansebas's comment explicitly.
624748c to
837cb3f
Compare
837cb3f to
2f372e4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (2)
packages/ui-components/src/Common/ChangeHistory/index.module.css:36
max-w-[calc(100vw-2rem)]producescalc(100vw-2rem)which is invalid CSS calc syntax (the-must be an operator, not part of the2remtoken). This can cause the max-width constraint to be ignored on small viewports.
w-[26rem]
max-w-[calc(100vw-2rem)]
.changeset/public-baths-open.md:5
- The PR description mentions expanding the main content width (issue #954 also calls out increasing the page max width), but this PR only changes the ChangeHistory dropdown width. Either update the PR description/changeset to scope it to ChangeHistory only, or include the main content/container width change as well.
Improve the width of ChangeHistory

Partially fix/es nodejs/doc-kit#954 by expanding the main content (if possible) and the change history