feat(replacements): add react-native-magic-modal to magic-modal - #44997
Open
GSTJ wants to merge 1 commit into
Open
feat(replacements): add react-native-magic-modal to magic-modal#44997GSTJ wants to merge 1 commit into
GSTJ wants to merge 1 commit into
Conversation
RahulGautamSingh
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds a
replacements:react-native-magic-modal-to-magic-modalpreset:react-native-magic-modal→magic-modal.Evidence:
magic-modal. This package still works and still tracks every release, since it depends onmagic-modaland re-exports it, but new code should installmagic-modalinstead. See https://github.com/GSTJ/magic-modal"Two notes on the rule shape, since this isn't a clean-cutover rename:
matchCurrentVersion: ">=10.0.0"rather than matching all old versions. v10 is where the rename landed, and it also dropped the React Native deps from the browser bundle, so it's a real major. Proposing the replacement only from 10.0.0 keeps the rename PR free of unrelated breaking changes, per the "propose a replacement only once the user is on a compatible version" rule increating-editing-renovate-presets.md. Users on 9.x get the ordinary major bump toreact-native-magic-modal@10.0.0first, then the replacement.replacementVersion. The old name isn't frozen — it keeps shipping in lockstep at the identical version number as a dependency plus re-export ofmagic-modal, soreact-native-magic-modal@10.xandmagic-modal@10.xare the same code. OmittingreplacementVersionmakes the replacement version-preserving and avoids a downgrade once the pair moves past 10.0.0. Same reasoning as the existingreplacements:framer-motion-to-motionentry, which is the closest precedent here (old name still published alongside the new one).Happy to switch to a pinned
replacementVersion: "10.0.0"or widenmatchCurrentVersionif you'd rather stay consistent with the more common frozen-old-package entries.Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
This PR was written by Claude Code (Opus 5), including the data entry and this description. I maintain both packages and verified the rename facts, the constraint choice, and the test runs myself.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Ran the existing data/preset validation rather than adding new tests, since
replacements.jsonentries are covered generically:vitest run lib/data/index.spec.ts lib/config/presets/internal/index.spec.ts— 1341 passed, including the new preset in theconfig:recommendedvalidationnode tools/validate-schema.ts—lib/data/replacements.jsonvalidates againsttools/schemas/replacements-schema.jsonprettier --check lib/data/replacements.json— cleanThe public repository: https://github.com/GSTJ/magic-modal