test: migrate math/base/special/asecd to ULP-based assertions - #13777
test: migrate math/base/special/asecd to ULP-based assertions#13777Planeshifter wants to merge 1 commit into
math/base/special/asecd to ULP-based assertions#13777Conversation
Replaces EPS-scaled relative-tolerance comparisons in the fixture loops with ULP-difference assertions via `@stdlib/assert/is-almost-same-value`, mirroring the pattern used in `math/base/special/asecdf` and `cotd`. Final ULP bound: 1 (measured minimum; ULP=0 fails 887/6009 assertions, ULP=1 passes all 6009 deterministically across repeated runs). Refs: #11352
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
left a comment
There was a problem hiding this comment.
The OP needs to be updated as described in the comments.
Summary
Migrates
math/base/special/asecdtest cases from relative-tolerance (EPS-scaled delta/tol) comparisons to ULP-difference assertions using@stdlib/assert/is-almost-same-value, per the guidance in #11352.test/test.jsandtest/test.native.jsboth updated. The idiom mirrors the already-converted sibling packagemath/base/special/asecdf(float32 variant) andmath/base/special/cotd.ULP = 1for both the negative-value and positive-value fixture blocks (used identically in bothtest.jsandtest.native.js).ULP = 0fails (887 of 6009 assertions fail),ULP = 1passes all 6009 assertions, confirmed deterministic across two consecutive runs.test/test.native.jsmirrors the same ULP value as the JS tests; the native add-on could not be built/tested in this environment (tests skip viatryRequire), consistent with prior converted packages in this family.Resolves a part of #11352.
Generated by Claude Code