chore: add missing notes in blas/ext/base and fix C benchmark labels - #13834
chore: add missing notes in blas/ext/base and fix C benchmark labels#13834Planeshifter wants to merge 2 commits into
blas/ext/base and fix C benchmark labels#13834Conversation
Propagates fix from 430fdea ("chore: clean-up") to sibling packages with the same defects: missing `## Notes` JSDoc sections in `*.native.js` files under `blas/ext/base` and mislabeled `# c::native::` TAP names in plain C benchmarks which do not go through the Node.js native add-on. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VRBkw1mmwKQqeuSHvhJQQa
Reverts the TAP label fix for `ndarray/base/sub2ind`, as the file has pre-existing cppcheck `constVariable` violations which fail the changed-files lint. The label fix for this file should land together with the lint clean-up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VRBkw1mmwKQqeuSHvhJQQa
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
CI status: all checks are green except one Generated by Claude Code |
|
Final CI status: the large Generated by Claude Code |
Description
This pull request:
developbetween 2026-07-31 and 2026-08-01 to sibling packages.Applies the two clean-up fixes from 430fdea (#13805) to the remaining sites that were missed in the original pass.
## NotesJSDoc section: 18*.native.jsfiles across 9blas/ext/basepackages (dsort2hp,dsort2sh,dsorthp,dsortsh,ssort2hp,ssort2sh,ssorthp,ssortsh,zlast-index-of-falsy) were missing the## Notessection present in their non-native counterparts. Each main native file and itsndarray.native.jssibling now carries the Notes content mirrored from the corresponding non-native file.benchmark/c/native/) printed names under thec::native::label reserved for add-on benchmarks. 198printflines across 74 files — spanningndarray/base,number/{float16,float32,float64}/base,complex/{float32,float64}/reim,strided/base,stats/base/dists/{chi/cdf,gamma/logcdf},random/base/shared,math/base/special/{cceil,hyp2f1}, andndarray/ctor— are relabeled toc::.Related Issues
No.
Questions
No.
Other
Validation: candidate sites were enumerated by pattern search over the full repository (
## Notespresent in the non-native file but absent in the paired*.native.js;c::native::labels outsidebenchmark/c/native/directories), then independently confirmed by two validation passes which read each site in full, an adaptation pass which derived each package's Notes content from its non-native counterpart and verified each bullet against the package's C sources, and a style-consistency pass against the conventions of 430fdea. Sites requiring cross-package changes or interpretation were excluded; none were flagged. The label convention was confirmed repo-wide: 1254 plain C benchmarks usec::, 432 add-on benchmarks underbenchmark/c/native/usec::native::, and none of the relabeled files link the Node.js add-on.ndarray/base/sub2ind/benchmark/c/benchmark.calso carries the mislabel (12 lines) but is excluded here: the file has pre-existing cppcheckconstVariableviolations which fail the changed-files lint, so its label fix should land together with the lint clean-up.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by an automated Claude Code fix-propagation routine, which identified the source commit, enumerated candidate sites, and validated each change with independent review passes before applying it.
@stdlib-js/reviewers