fix: Ensure naive module is available in test_stump.py (closes #1160) - #1169
Closed
botbikamordehai2-sketch wants to merge 1 commit into
Closed
fix: Ensure naive module is available in test_stump.py (closes #1160)#1169botbikamordehai2-sketch wants to merge 1 commit into
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1169 |
|
❌ This pull request has been automatically closed because the mandatory PR template was removed or not filled out. Please reopen or recreate this PR with the required information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The test_stump.py test file fails when run with the command
STUMPY_SEED=2633420849 NUMBA_DISABLE_JIT=1 NUMBA_ENABLE_CUDASIM=1 pixi run tests custom tests/test_stump.pybecause the 'naive' module used in the test is not found or not properly imported. The error arises from the import statementimport naivewhich cannot locate the module, causing the entire test session to fail.Fix
Modify test_stump.py to ensure the naive module is accessible by adding the parent directory to sys.path and adding a check to give a clear error message if the naive module is missing. This ensures the test can locate the naive module regardless of the current working directory.
Closes #1160